Skip to content
Snippets Groups Projects

Unit Tests

Merged gcorradini requested to merge preprocess_tests into preprocess
All threads resolved!

Goal: Frame out some basic unit tests for the legacy and new code to understand what the algorithm does and how it's changing

Edited by gcorradini

Merge request reports

Merged by gcorradinigcorradini 1 year ago (Feb 6, 2024 3:49pm UTC)

Merge details

  • Changes merged into preprocess with 3c9b5c37.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Julia Signell
  • I think this is nice! I really like the type hints and all the assertions that various functions are called.

  • Julia Signell approved this merge request

    approved this merge request

  • gcorradini added 2 commits

    added 2 commits

    Compare with previous version

  • gcorradini added 1 commit

    added 1 commit

    Compare with previous version

  • gcorradini added 1 commit

    added 1 commit

    • d478bcb2 - something with paths is not right

    Compare with previous version

  • gcorradini added 1 commit

    added 1 commit

    • d2a1d630 - remove output path until we fix tests

    Compare with previous version

  • gcorradini added 1 commit

    added 1 commit

    • 39f04e2f - get rid of the monthly example data

    Compare with previous version

  • gcorradini resolved all threads

    resolved all threads

  • @jsignell: pushed my changes when you get a chance give it another look/see and then I can merge it

  • gcorradini marked this merge request as ready

    marked this merge request as ready

  • gcorradini mentioned in commit 3c9b5c37

    mentioned in commit 3c9b5c37

  • merged

  • Please register or sign in to reply
    Loading