From 205aac1599c90ba52047ed653360720c0659d6c4 Mon Sep 17 00:00:00 2001 From: ranchodeluxe <greg.corradini@gmail.com> Date: Fri, 3 Feb 2023 06:49:05 -0800 Subject: [PATCH] done --- FireIO.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/FireIO.py b/FireIO.py index 2418569..12dfd15 100644 --- a/FireIO.py +++ b/FireIO.py @@ -2161,7 +2161,8 @@ def save_summarycsv(df, year, op="heritage", regnm=None): ######################################################### # IDEA 1: always additive and backward compatible ######################################################### - # plus: function handles regions and original assumptions without breaking original + # plus: note that the additional kwarg we want above `regnm` is optional, so the function handles regions + # and original flow with backward compatibility # plus: if we had tests around this we would see the old and new ones pass # minus: what if someone upstream doesn't care about code being regional? # minus: ugly (not to mention we'd have to apply this pattern everywhere in the code) -- GitLab